Add inverse derivative methods to BaseTransform#307
Open
marco-2023 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends BaseTransform with analytic derivative helpers for the inverse mapping (deriv_inverse, deriv2_inverse, deriv3_inverse) and adds finite-difference tests to validate them for BeckeRTransform.
Changes:
- Add generic inverse-derivative implementations to
BaseTransformbased on the forward derivatives evaluated atx = inverse(r). - Add finite-difference unit tests validating the new inverse-derivative methods for
BeckeRTransform.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/grid/rtransform.py |
Adds deriv_inverse, deriv2_inverse, and deriv3_inverse implementations to BaseTransform. |
src/grid/tests/test_transform.py |
Adds finite-difference tests for the new inverse-derivative methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inverse-derivative methods to
BaseTransform:deriv_inversederiv2_inversederiv3_inverseAdded FD test for each one.