Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

We need to phase out InverseRTransform #308

@marco-2023

Description

@marco-2023

InverseRTransform currently duplicates functionality already provided by BaseTransform (see #307), in particular the inverse transformation derivatives. This class should therefore be deprecated and removed.

At present, InverseRTransform is used by solve_poisson_bvp and solve_poisson_ivp. These functions use a transformation mapping $( r \in [0, \infty) \rightarrow [0, 1] )$, i.e. the inverse of the mapping used to construct the grid. Therefore, accepting the inverse transform as an argument.

  • This design should be revised to consistently use the forward transformation (from finite to infinite domain), and compute inverse-related quantities via BaseTransform where needed.

  • Similar changes will be required in the ode module.

  • Corresponding tests must also be refactored to reflect the updated transformation convention and ensure consistency with the new API.

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions