Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

For docker.yml checkout the tag used in pypi_publish#948

Merged
ngreenwald merged 2 commits into
mainfrom
github_actions/docker_checkout_ref
Mar 21, 2023
Merged

For docker.yml checkout the tag used in pypi_publish#948
ngreenwald merged 2 commits into
mainfrom
github_actions/docker_checkout_ref

Conversation

@srivarra

@srivarra srivarra commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #947.

How did you implement your changes

During the actions/checkout step, we specify the head_branch used. source

Remaining issues

None ATM.

@srivarra srivarra added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Mar 15, 2023
@srivarra srivarra self-assigned this Mar 15, 2023
@srivarra srivarra marked this pull request as ready for review March 15, 2023 23:39
@srivarra srivarra marked this pull request as draft March 15, 2023 23:40
@srivarra srivarra requested a review from camisowers March 21, 2023 03:49
@srivarra srivarra marked this pull request as ready for review March 21, 2023 03:49
@srivarra srivarra added this pull request to the merge queue Mar 21, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 21, 2023
@ngreenwald ngreenwald merged commit 8293e1f into main Mar 21, 2023
@ngreenwald ngreenwald deleted the github_actions/docker_checkout_ref branch March 21, 2023 17:32
@ngreenwald

Copy link
Copy Markdown
Member

Woops, i thought just the upload coverage step got skipped, but it was the actual testing run. My bad, looks like we'll need a follow-up PR to address the issue

@srivarra

srivarra commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

@ngreenwald @camisowers Looks like there was a new ipywidgets release, 8.0.5 earlier today. Gonna try take a look and see what needs to be fixed. Found a thread where others are running into the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker Workflow checks out main instead of a tagged branch

3 participants