Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

AnnData spatial analysis 1#1112

Draft
camisowers wants to merge 16 commits into
mainfrom
anndata_dists_and_neighbors
Draft

AnnData spatial analysis 1#1112
camisowers wants to merge 16 commits into
mainfrom
anndata_dists_and_neighbors

Conversation

@camisowers

@camisowers camisowers commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #1105.

How did you implement your changes

Assume that the user will use the AnnData conversion notebook once they have their completed cell table, and use this input for our spatial analyses computations.
Functions that were changed to take only anndata_dir as input, rather than the cell table and distance matrix directory path:

  • calc_dist_matrix()
  • create_neighborhood_matrix()
  • generate_cell_distance_analysis()

Notebook updates:

  • kmeans (+ tests)
  • mixing score

Remaining issues

  • Update notebooks
  • test_utils function to add dist mats to AnnData table
  • waiting on new ark release

@camisowers camisowers added the enhancement New feature or request label Jan 25, 2024
@camisowers camisowers self-assigned this Jan 25, 2024
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@camisowers

Copy link
Copy Markdown
Contributor Author

@alex-l-kong @srivarra Can you guys just take a preliminary look? I'll do a second pass when the notebook tests are running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AnnData spatial analysis part 1

1 participant