Update sp-set-firewall-rule-azure-sql-database.md#66
Merged
craigg-msft merged 1 commit intoMicrosoftDocs:livefrom Aug 29, 2017
Merged
Update sp-set-firewall-rule-azure-sql-database.md#66craigg-msft merged 1 commit intoMicrosoftDocs:livefrom
craigg-msft merged 1 commit intoMicrosoftDocs:livefrom
Conversation
Updated Permissions section to indicate that an Azure AD user assigned as the admin or member of an Azure AD group assigned as admin can also create and update rules. Incrementing the firewall end IP address by just 1 may create a false impression that they are individual IPs rather than a range. The description wasn't helpful either. Also remove curly quotes from parameter values. Also added some spaces between stored procedure parameter values, to be consistent with T-SQL docs (https://docs.microsoft.com/en-us/sql/relational-databases/stored-procedures/specify-parameters)
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Contributor
|
@SvenAelterman Thank you for the contribution. |
Contributor
|
@BYHAM please review. |
Contributor
|
#sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Permissions section to indicate that an Azure AD user assigned as the admin or member of an Azure AD group assigned as admin can also create and update rules.
Incrementing the firewall end IP address by just 1 may create a false impression that they are individual IPs rather than a range. The description wasn't helpful either.
Also remove curly quotes from parameter values.
Also added some spaces between stored procedure parameter values, to be consistent with T-SQL docs (https://docs.microsoft.com/en-us/sql/relational-databases/stored-procedures/specify-parameters)