Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Improve sample code to indicate a range is created#65

Merged
craigg-msft merged 1 commit intoMicrosoftDocs:livefrom
SvenAelterman:patch-2
Aug 29, 2017
Merged

Improve sample code to indicate a range is created#65
craigg-msft merged 1 commit intoMicrosoftDocs:livefrom
SvenAelterman:patch-2

Conversation

@SvenAelterman
Copy link
Copy Markdown
Contributor

Incrementing the firewall end IP address by just 1 may create a false impression that they are individual IPs rather than a range. The description wasn't helpful either.
Also removed "Windows" from "Windows Azure": It hasn't been called that in a while I think.
Also added some spaces between stored procedure parameter values, to be consistent with T-SQL docs (https://docs.microsoft.com/en-us/sql/relational-databases/stored-procedures/specify-parameters)

Incrementing the firewall end IP address by just 1 may create a false impression that they are individual IPs rather than a range. The description wasn't helpful either.
Also removed "Windows" from "Windows Azure": It hasn't been called that in a while I think. 
Also added some spaces between stored procedure parameter values, to be consistent with T-SQL docs (https://docs.microsoft.com/en-us/sql/relational-databases/stored-procedures/specify-parameters)
@msftclas
Copy link
Copy Markdown

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@craigg-msft
Copy link
Copy Markdown
Contributor

Thank you @SvenAelterman for the contribution to content.

@craigg-msft
Copy link
Copy Markdown
Contributor

@BYHAM please review.

@BYHAM
Copy link
Copy Markdown
Contributor

BYHAM commented Aug 29, 2017

Thank you for submitting this. @SvenAelterman Didn't you include these #65 changes in your #66 submission. (Which I have accepted.) If you agree, please cancel this one (#65).

@SvenAelterman
Copy link
Copy Markdown
Contributor Author

@BYHAM: note quite, there are two different articles, one for server-level and one for database-level. So yes, I made almost the same changes but that's because I believe both articles could be improved by making these changes.

Copy link
Copy Markdown
Contributor

@BYHAM BYHAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes. Thanks.

@BYHAM
Copy link
Copy Markdown
Contributor

BYHAM commented Aug 29, 2017

@SvenAelterman Ah. I didn't spot that right away. Thank you. Yes, I agree with the changes in the second topic, too, and I have accepted them.

@BYHAM
Copy link
Copy Markdown
Contributor

BYHAM commented Aug 29, 2017

#sign-off

@craigg-msft craigg-msft merged commit 884ee95 into MicrosoftDocs:live Aug 29, 2017
@BYHAM
Copy link
Copy Markdown
Contributor

BYHAM commented Aug 29, 2017

@craigg-msft Was not a duplicate after all. Just similar.

learn-build-service-prod Bot pushed a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Dinakar Nethi <dinethi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants