Fix issue closing alerts#1871
Merged
DavidWiseman merged 1 commit intotrimble-oss:mainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a post-deployment repair step to prevent Alert.ActiveAlerts identity values from being reused after a table rebuild, which can break alert closing when IDs collide with Alert.ClosedAlerts.
Changes:
- Add
Alert.ActiveAlerts_FixIdentitySeedstored procedure to detect conflicts and reseed/renumber as needed. - Execute the fix procedure during post-deployment.
- Include the new procedure in the SQL project build.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DBADashDB/Script.PostDeployment1.sql | Runs the new identity-seed repair proc during deployment. |
| DBADashDB/DBADashDB.sqlproj | Adds the new procedure script to the project build inputs. |
| DBADashDB/Alert/Procedures/ActiveAlerts_FixIdentitySeed.sql | Implements identity/ID conflict detection, renumbering, and reseeding logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
22a6ce4 to
273d80b
Compare
273d80b to
d7c5cb1
Compare
Fix issue with identity values being reused due to table rebuild. Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com>
d7c5cb1 to
aef524a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with identity values being reused due to table rebuild. #1870