Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Workflow Build step fix#1869

Merged
DavidWiseman merged 1 commit intotrimble-oss:mainfrom
DavidWiseman:PostBuild-fix
Apr 27, 2026
Merged

Workflow Build step fix#1869
DavidWiseman merged 1 commit intotrimble-oss:mainfrom
DavidWiseman:PostBuild-fix

Conversation

@DavidWiseman
Copy link
Copy Markdown
Collaborator

Fix issue where build step can fail due to exceeding GitHub API rate limit.

Fix issue where build step can fail due to exceeding GitHub API rate limit.
Copilot AI review requested due to automatic review settings April 27, 2026 10:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces CI build flakiness caused by unauthenticated GitHub API calls hitting rate limits during the post-build step that fetches the latest serialized-dataset-viewer release metadata.

Changes:

  • Add authenticated GitHub API requests (via GITHUB_TOKEN) and basic retry/backoff logic in PostBuild.ps1.
  • Pass GITHUB_TOKEN into the CLI build step across the main CI, release-tag, and variant CI workflows so the post-build script can authenticate.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
DBADashServiceConfig/PostBuild.ps1 Adds GitHub API request headers (User-Agent + optional Authorization) and retries to reduce transient failures.
.github/workflows/tag-create-release.yml Exposes GITHUB_TOKEN to the CLI build step to avoid unauthenticated rate limiting.
.github/workflows/ci_MinimalPermissions.yml Exposes GITHUB_TOKEN to the CLI build step to avoid unauthenticated rate limiting.
.github/workflows/ci_FolderDestination.yml Exposes GITHUB_TOKEN to the CLI build step to avoid unauthenticated rate limiting.
.github/workflows/ci_BucketDestination.yml Exposes GITHUB_TOKEN to the CLI build step to avoid unauthenticated rate limiting.
.github/workflows/ci.yml Exposes GITHUB_TOKEN to the CLI build step to avoid unauthenticated rate limiting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +21 to +25
} catch {
if ($attempt -eq $MaxRetries) { throw }
Write-Warning "GitHub API call failed (attempt $attempt/$MaxRetries): $_. Retrying..."
Start-Sleep -Seconds (5 * $attempt)
}
break
} catch {
if ($attempt -eq $MaxRetries) { throw }
Write-Warning "GitHub API call failed (attempt $attempt/$MaxRetries): $_. Retrying..."
@DavidWiseman DavidWiseman merged commit 72c4c82 into trimble-oss:main Apr 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants