fix(docker): drop scripts/ from workspaces array#4484
Conversation
`turbo prune sim --docker` strips `scripts/` from the pruned output (sim doesn't depend on it), but the pruned root package.json still listed it as a workspace, causing `bun install` to fail with "Workspace not found 'scripts'" in the Docker build. scripts/ is dev-only tooling that runs from the repo root via `bun run scripts/*.ts`. Its imports (glob, yaml) resolve against the root node_modules — they're already in root devDependencies. - Remove "scripts" from root workspaces array - Delete scripts/package.json (no longer a workspace, manifest unused) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Deletes the unused Reviewed by Cursor Bugbot for commit 89c99e9. Configure here. |
Greptile SummaryFixes a Docker build regression introduced in #4481 where
Confidence Score: 5/5Safe to merge — the change is a minimal, targeted fix that removes a workspace declaration causing Docker build failures, with no functional code altered. The root devDependencies already carry glob@13.0.0 and yaml@^2.8.1, so the scripts that previously relied on the workspace-scoped glob@11.1.0 continue to resolve correctly. The author validated all three affected check scripts and ran a local simulated Docker build successfully. No application code is touched. No files require special attention; all three changed files (package.json, scripts/package.json, bun.lock) are straightforward configuration/lockfile updates. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["turbo prune sim --docker"] --> B["Pruned package.json\n(apps/sim only)"]
B -->|"Before fix"| C["scripts/ listed in workspaces\nbut directory absent"]
C --> D["bun install\n❌ Workspace not found 'scripts'"]
B -->|"After fix"| E["scripts/ NOT in workspaces"]
E --> F["bun install\n✅ 1856 packages installed"]
G["Root devDependencies\nglob@13, yaml@^2.8"] --> F
H["scripts/*.ts\n(run via bun run from repo root)"] --> G
Reviews (1): Last reviewed commit: "fix(docker): drop scripts/ from workspac..." | Re-trigger Greptile |
Summary
The Docker build is failing on
stagingafter #4481 with:turbo prune sim --dockerstripsscripts/from the pruned output (sim doesn't depend on it), but the pruned rootpackage.jsonstill listed it as a workspace, sobun installerrors before it even starts.scripts/is dev-only tooling that runs from the repo root viabun run scripts/*.ts. Its imports (glob,yaml) resolve against the rootnode_modules— already in root devDependencies."scripts"from root workspaces arrayscripts/package.json(no longer a workspace, manifest unused)Test plan
bun installclean at rootbun run check:boundariespassesbun run check:realtime-prunepassesbun run check:api-validationpassesturbo prune sim --dockerthenbun install --ignore-scripts --linker=hoistedagainst the pruned output → 1856 packages installed cleanly