Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Tutorial improvements#4

Closed
imcotton wants to merge 5 commits into
reactjs:masterfrom
imcotton:tutorial-improvement
Closed

Tutorial improvements#4
imcotton wants to merge 5 commits into
reactjs:masterfrom
imcotton:tutorial-improvement

Conversation

@imcotton

@imcotton imcotton commented Sep 7, 2014

Copy link
Copy Markdown

Several AJAX related improvements:

  • Use promise callbacks from jqXHR
  • Use jQuery.proxy instead of Function.prototype.bind
  • Use shortcuts of jQuery.ajax
  • Remove redundant state updates within post succeed
  • Fetch comments only after each call has finished

Feel free to drop any suggestions, I'd happy to making rebase in order to trim it final.

@zpao

zpao commented Feb 2, 2015

Copy link
Copy Markdown
Member

It's been a few months and I think I'm just going to say meh to this. Parts are a bit simpler but otherwise I don't think it adds much. It might make sense to pull a couple of these ideas into a new version of the tutorial though. We can revisit if/when we do that. Thanks though!

@zpao zpao closed this Feb 2, 2015
shenxl pushed a commit to shenxl/react-tutorial that referenced this pull request Sep 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants