Add disabled prop to StrictReactDOMSelectProps#495
Open
galinski-n wants to merge 1 commit into
Open
Conversation
The \`disabled\` prop was missing from \`StrictReactDOMSelectProps\` while present on input, textarea, button, option, and optgroup. \`<select disabled>\` is valid HTML and already worked at runtime (it's in the prop allowlist and handled by the native renderer), so typed consumers hit a false type error. This adds the type declaration; the generated \`.d.ts\` now exposes it to TS consumers too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
disabledprop was missing fromStrictReactDOMSelectPropswhile present on input, textarea, button, option, and optgroup.<select disabled>is valid HTML and already worked at runtime (it's in the prop allowlist and handled by the native renderer), so typed consumers hit a false type error. This adds the type declaration; the generated.d.tsnow exposes it to TS consumers too.Solves #465