Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Button remains unclickable after disabled state changes #491

@pmleczek

Description

@pmleczek

Describe the issue

On Android if html.button state is set to disabled and then back to enabled the pressable itself remains unclickable, while it's children are clickable as expected. As with other similar issues in React Native a workaround is to set a key based on disabled state, but this issue doesn't seem to come from React Native, as it doesn't happen in React Native.

On iOS the button regains clickability as expected.

Expected behavior

Like on iOS, the pressable on Android should become clickable when the disabled state changes back to false.

Steps to reproduce

Platform: Android
OS version: 16.0 ("Baklava"); API 36.0
React version: 19.2.3
React Native version: 0.85.3
RSD version: 0.0.55

  1. Use the below example:
import { useState } from "react";
import { Button, Pressable, Text, View } from "react-native";
import { css, html } from "react-strict-dom";

export default function RootLayout() {
  const [buttonDisabled, setButtonDisabled] = useState(false);
  const [rnPresses, setRnPresses] = useState(0);
  const [rsdPresses, setRsdPresses] = useState(0);

  return (
    <View
      style={{ flex: 1, backgroundColor: "white", alignItems: "center", justifyContent: "center" }}
    >
      <Button
        title={"Toggle button disabled - now: " + buttonDisabled.toString()}
        onPress={() => {
          setButtonDisabled((prev) => !prev);
        }}
      />
      <View>
        <Text>RN Pressable - {rnPresses} presses</Text>
        <Pressable
          disabled={buttonDisabled}
          style={({ pressed }) => [
            { backgroundColor: "lightgreen", padding: 16 },
            pressed && { opacity: 0.5 },
          ]}
          onPress={() => {
            setRnPresses((prev) => prev + 1);
          }}
        >
          <Text style={{ backgroundColor: "black", color: "white", padding: 8 }}>Press me</Text>
        </Pressable>
      </View>
      <View>
        <Text>RSD Button - {rsdPresses} presses</Text>
        <html.button
          disabled={buttonDisabled}
          style={styles.button}
          onClick={() => {
            setRsdPresses((prev) => prev + 1);
          }}
        >
          <html.span style={styles.buttonText}>Press me</html.span>
        </html.button>
      </View>
    </View>
  );
}

const styles = css.create({
  button: {
    backgroundColor: "lightblue",
    opacity: {
      default: 1,
      ":active": 0.5,
    },
    padding: 16,
  },
  buttonText: {
    backgroundColor: "black",
    color: "white",
    padding: 8,
  },
});
  1. Run the app on Android device/emulator
  2. Verify that, for both RN and RSD cases, both pressable and it's children trigger press event (press count increases)
  3. Toggle button disabled state to true
  4. Toggle button disabled state to false
  5. Verify that for RN case both pressable and children regained clickability, while in RSD case only the label can be clicked to trigger an event

Test case

No response

Additional comments

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions