PEP 277: Unicode file name support

[loewis]

BPO	594001
Nosy	@gvanrossum, @tim-one, @loewis, @mhammond
Files	pep277.txt pep277.txt: Version 2 unicode_comments.txt: Comments on the patch pep277-2.txt: Better version of that patch that doesn't crash anything! doc.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mhammond'
closed_at = <Date 2002-10-05.09:47:07.000>
created_at = <Date 2002-08-12.11:33:37.000>
labels = ['OS-windows']
title = 'PEP 277: Unicode file name support'
updated_at = <Date 2002-10-05.09:47:07.000>
user = 'https://github.com/loewis'

bugs.python.org fields:

activity = <Date 2002-10-05.09:47:07.000>
actor = 'loewis'
assignee = 'mhammond'
closed = True
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2002-08-12.11:33:37.000>
creator = 'loewis'
dependencies = []
files = ['4506', '4507', '4508', '4509', '4510']
hgrepos = []
issue_num = 594001
keywords = ['patch']
message_count = 25.0
messages = ['40910', '40911', '40912', '40913', '40914', '40915', '40916', '40917', '40918', '40919', '40920', '40921', '40922', '40923', '40924', '40925', '40926', '40927', '40928', '40929', '40930', '40931', '40932', '40933', '40934']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'tim.peters', 'loewis', 'mhammond', 'nnorwitz']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue594001'
versions = []

[loewis]

This patch is in an updated version of the patch [1]
mentioned in the PEP. In addition to merging it with
the CVS, it fixes a few formatting problems.

[gvanrossum]

Logged In: YES
user_id=6380

I'd make unicode_filenames() a macro that expands to 0 on
platforms without this wart. I'd also test for wfunc!=NULL
before calling unicode_filenames().

There's a lot of hairy code here. Are you sure that there
are test cases in the test suite that exercise all of it?

Aren't there some #ifdefs missing? posix_[12]str have code
that's only relevant for Windows but isn't #ifdef'ed out
like it is elsewhere.

There should probably be a separate #define in pyport.h to
test for this that's equivalent to defined(MS_WINDOWS) &&
!defined(Py_UNICODE_WIDE), so this can be uniformly tested
to see whether this code is necessary.

[loewis]

Logged In: YES
user_id=21627

This is a new version:

• wrapped all Windows wide API code with #ifdef
  Py_WIN_WIDE_FILENAMES
• added test case

Mark, can you please take a look at this?

[loewis]

Logged In: YES
user_id=21627

Tim, can you review this?

[tim-one]

Logged In: YES
user_id=31435

Sorry, Martin, bouncing back to Mark -- I really don't know
anything about the Windows filename APIs.

[loewis]

Logged In: YES
user_id=21627

Mark, can you please indicate whether you will review this
patch?

[mhammond]

Logged In: YES
user_id=14198

Will review this instant - sorry for the delay.

[mhammond]

Logged In: YES
user_id=14198

Uploading text file with my comments on the patch. Also
uploading a new patch with these corrections and even better
(?) error handling.

[mhammond]

Logged In: YES
user_id=14198

Back to Martin for comments on my comments ;)