Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

SDK-1549 Reconnect restarts subscribe loop regardless of the state#220

Merged
kleewho merged 2 commits into
masterfrom
SDK-1549
Nov 4, 2021
Merged

SDK-1549 Reconnect restarts subscribe loop regardless of the state#220
kleewho merged 2 commits into
masterfrom
SDK-1549

Conversation

@kleewho

@kleewho kleewho commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

fix: Reconnect always restarts the subscription connection

bartk
bartk previously approved these changes Oct 29, 2021

@bartk bartk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is one question.

Comment thread src/main/java/com/pubnub/api/builder/dto/PubSubOperation.java
@kleewho

kleewho commented Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

@client-engineering-bot help

@github-actions

github-actions Bot commented Nov 4, 2021

Copy link
Copy Markdown

@kleewho some information which may help you listed below.

Available commands and options

List of comments which can trigger deployment action:

  • @client-engineering-bot help to get this information
  • @client-engineering-bot release [<project>] [as [<version>]] complete preparation before merge to default branch.
    • project - optional identifier of project from .github/workflows/release/products.json which should be released.
      By default repository root will be used.
    • version - optional custom version with which release should be done.
      By default next version is based on changes mentioned in initial PR comment.

@kleewho

kleewho commented Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

@client-engineering-bot release

@kleewho kleewho merged commit 88ab518 into master Nov 4, 2021
@kleewho kleewho deleted the SDK-1549 branch November 4, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants