This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Fix issue with underscores in package names. Fixes #91#92
Merged
Conversation
Before this commit, `python_pip` reinstalled packages that contain underscores in their names. More details at poise#91
coderanger
added a commit
that referenced
this pull request
Feb 25, 2014
Fix issue with underscores in package names. Fixes #91
Contributor
Author
|
@coderanger: when is the next release? I would like to remove my workarounds and get the official fix. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit,
python_pipreinstalled packages that contain underscores in their names.More details at #91
PS.: I ran into some issues with the tests and VM memory size. In my local development I increased memory size to 1030MB and it worked fine. The error I got was
FATAL: Chef::Exceptions::ChildConvergeError: Chef run process terminated by signal 9 (KILL), that I did some research and it is related to not enough memory. I still don't know why that happened.