Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Adding fix to email with broke quotes. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinaldocoelho merged 1 commit into from
Apr 3, 2017
Merged

Adding fix to email with broke quotes. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Class Library/ActiveUp.Net.Common/Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,15 +1037,15 @@ public static AddressCollection ParseAddresses(string input)
/// <returns></returns>
public static Address ParseAddress(string input)
{
input = input.TrimEnd(';');
input = (input ?? "").Replace("\"", "").TrimEnd(';');
try
{
if (!input.Contains("<"))
return new Address { Email = RemoveWhiteSpaces(input) };

Address address = null;

Match displayNameMatch = Regex.Match(input, "(\"?(.+)(\"?(?=\\s?<)|(?=<)))");
var displayNameMatch = Regex.Match(input, "(\"?(.+)(\"?(?=\\s?<)|(?=<)))");
if (displayNameMatch.Success)
address = new Address(input.Replace(displayNameMatch.Value, string.Empty).Trim().Trim(new[] { '<', '>' }), displayNameMatch.Groups[1].Value);
else
Expand All @@ -1054,7 +1054,7 @@ public static Address ParseAddress(string input)
CleanupAddress(address);
return address;
}
catch
catch (Exception)
{
return new Address { Email = input };
}
Expand Down
8 changes: 8 additions & 0 deletions Class Library/ActiveUp.Net.Tests/Common/ParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,14 @@ public void should_parse_address_with_no_closing_quote_after_display_name()
address.Name.ShouldEqual("Display Name only one quote");
}

[Test]
public void should_parse_address_with_invalid_empty_quote()
{
var address = Parser.ParseAddress("\"\" Invoice@dymak.nl\"");
address.Email.ShouldEqual("Invoice@dymak.nl");
address.Name.ShouldEqual("");
}

/// <summary>
/// [discussion:641270] - Created discussion to validate if this test is rigth.
/// </summary>
Expand Down