Move generated live_reload patterns to runtime config#6722
Open
jechol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phx.newcurrently generateslive_reloadpatterns inconfig/dev.exs.Those patterns are runtime-only endpoint configuration, read by
Phoenix.LiveReloaderfrom the endpoint config when the live reload socket joins. They do not need to be part of compile-time configuration.Keeping them in compile config can lead to unnecessary recompilation because Mix stores compile config in the Elixir compiler manifest, and equivalent regex literals are not term-equal across evaluations:
If a config file is touched, Mix may re-check compile config and see the newly evaluated regex values as changed even when the config source did not meaningfully change.
This moves the generated
live_reloadconfig toruntime.exsunder the development environment, preserving behavior while avoiding unstable regex terms in compile config.