Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix(PlusIcon): Replace PlusIcon with RhUiAddIcon#12520

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-plus-icon-with-rh-ui-add
Open

fix(PlusIcon): Replace PlusIcon with RhUiAddIcon#12520
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-plus-icon-with-rh-ui-add

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated icons across Card, MenuToggle, NumberInput, Slider, Tabs, and Tile components to display new designs from the Red Hat UI design system. The "Add" and "Plus" action buttons throughout the application now feature the updated icon visuals. All component functionality, behavior, and user interactions remain completely unchanged.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7abe1ee-8eee-41b2-871e-cd7880b974ad

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and ec81521.

⛔ Files ignored due to path filters (2)
  • packages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/deprecated/components/Tile/__tests__/__snapshots__/Tile.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (12)
  • packages/react-core/src/components/Card/examples/Card.md
  • packages/react-core/src/components/Card/examples/CardTile.tsx
  • packages/react-core/src/components/Card/examples/CardTileMulti.tsx
  • packages/react-core/src/components/MenuToggle/examples/MenuToggle.md
  • packages/react-core/src/components/MenuToggle/examples/MenuToggleCustomIcon.tsx
  • packages/react-core/src/components/NumberInput/NumberInput.tsx
  • packages/react-core/src/components/Slider/examples/Slider.md
  • packages/react-core/src/components/Slider/examples/SliderActions.tsx
  • packages/react-core/src/components/Tabs/Tabs.tsx
  • packages/react-core/src/deprecated/components/Tile/__tests__/Tile.test.tsx
  • packages/react-core/src/deprecated/components/Tile/examples/Tile.md
  • packages/react-core/src/deprecated/components/Tile/examples/TileWithIcon.tsx

Walkthrough

PlusIcon is replaced with RhUiAddIcon across component source files (NumberInput, Tabs), example components (CardTile, CardTileMulti, MenuToggleCustomIcon, SliderActions, TileWithIcon), markdown documentation files, and snapshot tests for the deprecated Tile component.

Changes

PlusIcon → RhUiAddIcon replacement

Layer / File(s) Summary
Component implementation icon swap
packages/react-core/src/components/NumberInput/NumberInput.tsx, packages/react-core/src/components/Tabs/Tabs.tsx
NumberInput and Tabs update their icon imports and replace PlusIcon with RhUiAddIcon in the plus/add button render output.
Examples and docs icon swap
packages/react-core/src/components/Card/examples/Card.md, packages/react-core/src/components/Card/examples/CardTile.tsx, packages/react-core/src/components/Card/examples/CardTileMulti.tsx, packages/react-core/src/components/MenuToggle/examples/MenuToggle.md, packages/react-core/src/components/MenuToggle/examples/MenuToggleCustomIcon.tsx, packages/react-core/src/components/Slider/examples/Slider.md, packages/react-core/src/components/Slider/examples/SliderActions.tsx, packages/react-core/src/deprecated/components/Tile/examples/Tile.md, packages/react-core/src/deprecated/components/Tile/examples/TileWithIcon.tsx
All example components and their paired markdown docs replace PlusIcon imports and JSX usages with RhUiAddIcon across Card tile variants, MenuToggle custom-icon variants, Slider action buttons, and Tile variants.
Tile snapshot test icon swap
packages/react-core/src/deprecated/components/Tile/__tests__/Tile.test.tsx
Tile snapshot tests replace PlusIcon with RhUiAddIcon for the icon, stacked-icon, and stacked-large-icon test cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(PlusIcon): Replace PlusIcon with RhUiAddIcon' directly and accurately summarizes the main change across all files in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-plus-icon-with-rh-ui-add branch from 1a08782 to ec81521 Compare June 23, 2026 22:23
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 23, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants