Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix(UndoIcon): Replace UndoIcon with RhUiUndoIcon#12515

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-undo-icon-with-rh-ui-undo
Open

fix(UndoIcon): Replace UndoIcon with RhUiUndoIcon#12515
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-undo-icon-with-rh-ui-undo

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated undo icon variant across ToggleGroup component examples and demo applications for improved visual consistency.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c268407f-673c-4490-bc07-ce8da0c6bce6

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and 12e675d.

📒 Files selected for processing (4)
  • packages/react-core/src/components/ToggleGroup/examples/ToggleGroup.md
  • packages/react-core/src/components/ToggleGroup/examples/ToggleGroupIcon.tsx
  • packages/react-core/src/components/ToggleGroup/examples/ToggleGroupTextIcon.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToggleGroupDemo/ToggleGroupDemo.tsx

Walkthrough

Replaces UndoIcon with RhUiUndoIcon (from rh-ui-undo-icon) across four files: the ToggleGroup markdown doc, two example components (ToggleGroupIcon.tsx, ToggleGroupTextIcon.tsx), and the integration demo (ToggleGroupDemo.tsx). Only imports and icon render props are changed.

Changes

ToggleGroup undo icon replacement

Layer / File(s) Summary
Icon swap in ToggleGroup examples and docs
packages/react-core/src/components/ToggleGroup/examples/ToggleGroup.md, packages/react-core/src/components/ToggleGroup/examples/ToggleGroupIcon.tsx, packages/react-core/src/components/ToggleGroup/examples/ToggleGroupTextIcon.tsx
Replaces UndoIcon import and all render sites with RhUiUndoIcon from rh-ui-undo-icon in the two example components and the markdown doc.
Icon swap in integration demo
packages/react-integration/demo-app-ts/src/components/demos/ToggleGroupDemo/ToggleGroupDemo.tsx
Swaps the UndoIcon import and the "undo icon button" ToggleGroupItem icon prop to use RhUiUndoIcon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing UndoIcon with RhUiUndoIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants