Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 4#12504

Open
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part4
Open

fix(InfrastructureIcons): replaced with RH brand icons part 4#12504
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part4

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

Covers FileUpload, Download, Upload, and Clone icons

Additional issues:

Summary by CodeRabbit

  • Style
    • Refreshed icon designs across the component library to use PatternFly React UI icons for enhanced visual consistency. Updated components include CodeEditor, Button, FileUpload, MultipleFileUpload, Toolbar, and Table with modernized upload, download, document, and copy action icons visible throughout the interface, examples, and documentation.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d896988a-2e5b-4b61-9903-2a0073c74d8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR updates multiple component examples, demos, and one editor component to use RH UI icon variants for upload, download, document, and copy actions, and adjusts FileUpload markdown code-fence spacing in its example documentation.

Changes

Icon refresh across components, examples, and demos

Layer / File(s) Summary
Upload and download icon replacements
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx, packages/react-core/src/components/Button/examples/*, packages/react-core/src/components/MultipleFileUpload/examples/*, packages/react-core/src/demos/MultipleFileUploadDemos.md, packages/react-core/src/demos/examples/MultipleFileUpload/*, packages/react-core/src/demos/Toolbar.md, packages/react-core/src/demos/examples/Toolbar/*
Upload and download actions now import and render RhUiUploadIcon or RhUiDownloadIcon in the editor, examples, and demos.
File upload preview and markdown cleanup
packages/react-core/src/components/FileUpload/examples/FileUpload.md, packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx
FileUpload examples switch to RhUiDocumentFillIcon, and the markdown example sections adjust code-fence and spacing lines around embedded example blocks.
Copy icon replacements in toolbar and table examples
packages/react-core/src/components/Toolbar/examples/*, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableSortableResponsive.tsx
Toolbar, integration, and table examples replace clone icons with RhUiCopyFillIcon in imports and button icon props.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • kmcfaul
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing infrastructure icons with RH brand icons as part 4 of a multi-part initiative.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants