fix(InfrastructureIcons): replaced with RH brand icons part 3#12503
fix(InfrastructureIcons): replaced with RH brand icons part 3#12503thatblindgeye wants to merge 4 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 8 minutes and 46 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughAcross Nav, TreeView, Table (current and deprecated), MultipleFileUpload components, and their associated examples, demos, and tests, legacy PatternFly icons ( ChangesRhUI Icon Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12503.surge.sh A11y report: https://pf-react-pr-12503-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looks good - just one question about a maybe-orphan import.
| import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon'; | ||
| import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon'; | ||
| import FolderIcon from '@patternfly/react-icons/dist/esm/icons/folder-icon'; | ||
| import RhUiFolderFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-folder-fill-icon'; |
What: Towards #12399
Covers FileIcon, FileImageIcon, FolderIcon, and FolderOpenIcon
Additional issues:
Summary by CodeRabbit
Release Notes
Style
Documentation & Examples