Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 3#12503

Open
thatblindgeye wants to merge 4 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part3
Open

fix(InfrastructureIcons): replaced with RH brand icons part 3#12503
thatblindgeye wants to merge 4 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part3

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

Covers FileIcon, FileImageIcon, FolderIcon, and FolderOpenIcon

Additional issues:

Summary by CodeRabbit

Release Notes

  • Style

    • Replaced legacy icon components with new Rhythm UI icon variants throughout the library, including document, folder, and image icons.
  • Documentation & Examples

    • Updated all example components, test files, and documentation across file upload, navigation, tree view, table, and Compass demo features to use the new icons.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@thatblindgeye, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 46 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20a9ad3d-7b0f-4d03-a7fe-4aeab1f51d86

📥 Commits

Reviewing files that changed from the base of the PR and between 789b057 and 2f78608.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatusItem.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-core/src/components/TreeView/examples/TreeView.md

Walkthrough

Across Nav, TreeView, Table (current and deprecated), MultipleFileUpload components, and their associated examples, demos, and tests, legacy PatternFly icons (FolderIcon, FolderOpenIcon, FileIcon, FileImageIcon) are replaced with RhUI fill icon equivalents (RhUiFolderFillIcon, RhUiFolderOpenFillIcon, RhUiDocumentFillIcon, RhUiImageFillIcon).

Changes

RhUI Icon Migration

Layer / File(s) Summary
MultipleFileUploadStatusItem default icon swap and tests
packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatusItem.tsx, packages/react-core/src/components/MultipleFileUpload/__tests__/MultipleFileUploadStatusItem.test.tsx
Replaces FileIcon with RhUiDocumentFillIcon as the rendered fallback when no fileIcon prop is provided; updates tests to use RhUiImageFillIcon in place of FileImageIcon.
Nav examples and demos folder icon update
packages/react-core/src/components/Nav/examples/NavIcons.tsx, packages/react-core/src/components/Nav/examples/Nav.md, packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx, packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx, packages/react-core/src/demos/Compass/Compass.md, packages/react-core/src/demos/Nav.md, packages/react-core/src/demos/Page.md
Replaces FolderIcon/FolderOpenIcon with RhUiFolderFillIcon/RhUiFolderOpenFillIcon in icon props for NavItem and NavExpandable across all Nav examples and demo files.
TreeView examples folder icon update
packages/react-core/src/components/TreeView/examples/TreeViewWithIcons.tsx, packages/react-integration/demo-app-ts/src/components/demos/TreeViewDemo/TreeViewDemo.tsx
Updates icon, expandedIcon, and action button folder icons in TreeView examples and the integration demo to use RhUI fill icons.
Table and LegacyTable tree examples folder icon update
packages/react-table/src/components/Table/examples/TableTree.tsx, packages/react-table/src/components/Table/examples/Table.md, packages/react-table/src/deprecated/components/Table/examples/LegacyTableTree.tsx, packages/react-table/src/deprecated/components/Table/examples/Table.md
Replaces FolderIcon/FolderOpenIcon with RhUiFolderFillIcon/RhUiFolderOpenFillIcon in renderRows/buildRows expanded/collapsed logic and corresponding doc import blocks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • phcox
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: replacing Infrastructure icons with RedHat brand icons as the third part of a series addressing issue #12399.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one question about a maybe-orphan import.

import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import FolderIcon from '@patternfly/react-icons/dist/esm/icons/folder-icon';
import RhUiFolderFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-folder-fill-icon';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants