Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix(ClockIcon): Replace ClockIcon with RhUiClockFillIcon#12464

Merged
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-clock-icon-with-rh-ui-clock-fill
Jun 17, 2026
Merged

fix(ClockIcon): Replace ClockIcon with RhUiClockFillIcon#12464
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-clock-icon-with-rh-ui-clock-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated the TextInput example documentation and custom icon example to use RhUiClockFillIcon instead of the previous clock icon.
    • Updated the RTL demo (including the paginated table status label) to use RhUiClockFillIcon for the “Down” indicator.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b4b27e93-0a34-487f-9165-ae1ecfd9f3ac

📥 Commits

Reviewing files that changed from the base of the PR and between 7f6ebbd and ff30fd2.

📒 Files selected for processing (4)
  • packages/react-core/src/components/TextInput/examples/TextInput.md
  • packages/react-core/src/components/TextInput/examples/TextInputCustomIcon.tsx
  • packages/react-core/src/demos/RTL/RTL.md
  • packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-core/src/components/TextInput/examples/TextInputCustomIcon.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/react-core/src/components/TextInput/examples/TextInput.md
  • packages/react-core/src/demos/RTL/RTL.md
  • packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx

Walkthrough

Four example and demo files update their clock icon component from ClockIcon to RhUiClockFillIcon. Changes include import statements and component usages across TextInput examples and RTL demo files.

Changes

Icon Component Migration

Layer / File(s) Summary
TextInput examples
packages/react-core/src/components/TextInput/examples/TextInput.md, packages/react-core/src/components/TextInput/examples/TextInputCustomIcon.tsx
Import statements and component usage for the custom icon example are updated to use RhUiClockFillIcon instead of ClockIcon.
RTL demo
packages/react-core/src/demos/RTL/RTL.md, packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx
Import statements and the "Down" status label icon in PaginatedTable are updated to use RhUiClockFillIcon instead of ClockIcon.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • patternfly/patternfly-react#12468: Both PRs update icon imports/usage inside the RTL demo's PaginatedTable.tsx (swapping different status label icons: ClockIconRhUiClockFillIcon vs WalkingIconRhUiRunningIcon), indicating they're part of the same icon-replacement effort.

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing ClockIcon with RhUiClockFillIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-clock-icon-with-rh-ui-clock-fill branch from 7f6ebbd to ff30fd2 Compare June 17, 2026 17:37
@rebeccaalpert rebeccaalpert merged commit e9d08f9 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants