fix: change comment on revokeOAuth2LoginSessions#3853
Merged
aeneasr merged 1 commit intoOct 10, 2024
Conversation
aeneasr
approved these changes
Oct 7, 2024
alnr
requested changes
Oct 7, 2024
alnr
left a comment
Contributor
There was a problem hiding this comment.
Is this correct? I don't think it is. Need to look at this in detail.
Member
|
This is correct, due to a cascade delete of request_id, see also: https://github.com/orgs/ory/discussions/118 |
Member
|
Contributor
|
This PR is incorrect. Revoking a login session does not revoke access tokens and also does not revoke consent! |
Contributor
|
It also does not revoke refresh tokens. |
Contributor
|
Added comment in https://github.com/orgs/ory/discussions/118 |
alnr
added a commit
that referenced
this pull request
Oct 10, 2024
Contributor
|
Revert #3858 |
aeneasr
pushed a commit
that referenced
this pull request
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
This is not an issue, but the related discussions can be found below.
https://github.com/orgs/ory/discussions/118
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments