cast override suggestion#32
Closed
sergeant-wizard wants to merge 1 commit into
Closed
Conversation
Contributor
|
I seem to remember reading something about this on of Scott Meyers' C++ books a long time ago. I highly recommend them. Anyway, C++ typecast rules are complicated, especially for pointers (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, guys!
Nice project!
I'm just curious, can't we override the type casts so that we don't have to specify
Json::Value::as*()?For example, with your current version, we have to specify the type of the values like:
However, by applying this pull request, we can do something like:
without specifying the type, and leave it to the compiler to figure it out from the context.
You may have discussed this prior to transferring to GitHub, but I'd really like to know why you're adapting explicit type specifications without using the features of C++.
Thanks in advance :)