Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix: 🐛 Fix bug that prevents breakpoints to be hit inside custom gate definition#7

Merged
DRovara merged 1 commit into
mainfrom
bugfix/breakpoints-in-gate-definitions
Aug 9, 2024
Merged

fix: 🐛 Fix bug that prevents breakpoints to be hit inside custom gate definition#7
DRovara merged 1 commit into
mainfrom
bugfix/breakpoints-in-gate-definitions

Conversation

@DRovara

@DRovara DRovara commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

Description

Custom gate definitions are defined with start position at gate... and end position at their closing }. Therefore, when putting a breakpoint at any location within those bounds, it was always attached to the function. Now, if a breakpoint would be attached to a function, we first check if it would fit better to one of the gates inside it.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

…finitions

Custom gate definitions are defined with start position at `gate...` and end position at their closing `}`. Therefore, when putting a breakpoint at any location within those bounds, it was always attached to the function. Now, if a breakpoint would be attached to a function, we first check if it would fit better to one of the gates inside it.
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@DRovara DRovara merged commit 5036680 into main Aug 9, 2024
@DRovara DRovara deleted the bugfix/breakpoints-in-gate-definitions branch August 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants