AdvLoggerPkg: DecodeUefiLog handle frequency errors.#824
Merged
makubacki merged 1 commit intoFeb 6, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #824 +/- ##
================================================
Coverage ? 4.71%
================================================
Files ? 36
Lines ? 4199
Branches ? 276
================================================
Hits ? 198
Misses ? 3999
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuqin12
approved these changes
Feb 6, 2026
makubacki
approved these changes
Feb 6, 2026
When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds. Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log.
5cb176b to
aa971ee
Compare
Member
|
@apop5, I went ahead and rebased with autocomplete so I can rebase my PR on the Python script change. |
apop5
added a commit
that referenced
this pull request
Feb 25, 2026
## Description When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds. Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested On a physical platform where no timer frequency was reported, encountered a python exception. After change, log was correctly retrieved and displays a timestamp of 0. ## Integration Instructions No integration necessary.
apop5
added a commit
to apop5/mu_plus
that referenced
this pull request
Feb 26, 2026
## Description When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds. Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested On a physical platform where no timer frequency was reported, encountered a python exception. After change, log was correctly retrieved and displays a timestamp of 0. ## Integration Instructions No integration necessary.
apop5
added a commit
to apop5/mu_plus
that referenced
this pull request
Mar 3, 2026
## Description When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds. Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested On a physical platform where no timer frequency was reported, encountered a python exception. After change, log was correctly retrieved and displays a timestamp of 0. ## Integration Instructions No integration necessary.
apop5
added a commit
that referenced
this pull request
Mar 3, 2026
## Description When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds. Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested On a physical platform where no timer frequency was reported, encountered a python exception. After change, log was correctly retrieved and displays a timestamp of 0. ## Integration Instructions No integration necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling DecodeUefiLog, if the system was not able to provide a frequency in the log, it will be reported as 0. With no verification check of a zero frequency, DecodeUefiLog would attempt a divide by zero when converting time to nano seconds.
Add a check that prevents divide by zero. This will report times of 0 for all timestamps in the decoded log.
How This Was Tested
On a physical platform where no timer frequency was reported, encountered a python exception.
After change, log was correctly retrieved and displays a timestamp of 0.
Integration Instructions
No integration necessary.