Dev branch tear down [Rebase & FF]#753
Merged
apop5 merged 19 commits intoSep 18, 2025
Merged
Conversation
Collaborator
Author
|
Dependent on microsoft/mu_tiano_plus#451 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #753 +/- ##
=================================================
Coverage ? 11.47%
=================================================
Files ? 136
Lines ? 22094
Branches ? 2515
=================================================
Hits ? 2536
Misses ? 19526
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuqin12
approved these changes
Sep 12, 2025
kuqin12
approved these changes
Sep 12, 2025
kuqin12
approved these changes
Sep 12, 2025
kuqin12
approved these changes
Sep 12, 2025
kuqin12
approved these changes
Sep 12, 2025
Javagedes
approved these changes
Sep 17, 2025
makubacki
reviewed
Sep 17, 2025
makubacki
approved these changes
Sep 17, 2025
makubacki
left a comment
Member
There was a problem hiding this comment.
Labels in the PR description need to be updated.
antklein
approved these changes
Sep 17, 2025
This reverts commit a6a9d44. Reverting the commit to be able to cleanly apply Tpm2DebugLib removal that was staged in dev/202502 branch. Will be reapplied using dev branch commit.
MuSecureBootKeySelectorLib is being updated to detect if the keystore doesn't match one of our expected configurations but does match something MSFT could have serviced. (cherry picked from commit 1d7af0a)
## Description Platforms with multiple die(s) can have a die offset address added to common GIC address to reach die-specific GIC address. Hence, adding support to get die information from MpServices and use a platform specific PCD to calculate die offset address which is then added to base GIC addresses. The existing implementation will remain unchanged since PcdPlatformGICOffset is set to 0 by default. Platforms can override this value to its specific need. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested Tested on MSFT platform, booting to UEFI shell ## Integration Instructions N/A --------- Co-authored-by: shriramma <shriramma@microsoft.com>
The library instance was removed in microsoft/mu_tiano_plus#426. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Updates the files to include changes surrounding the TPM Replay testing code. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
synced local file(s) with [microsoft/mu_devops](https://github.com/microsoft/mu_devops). 🤖: View the [Repo File Sync Configuration File](https://github.com/microsoft/mu_devops/blob/main/.sync/Files.yml) to see how files are synced. --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#16412961993](https://github.com/microsoft/mu_devops/actions/runs/16412961993) Signed-off-by: Project Mu UEFI Bot <uefibot@microsoft.com> Co-authored-by: mu-automation[bot] <204385837+mu-automation[bot]@users.noreply.github.com>
Bumps [regex](https://github.com/mrabarnett/mrab-regex) from 2024.11.6 to 2025.7.31. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ft#727) ## Description When dereferencing `PcdAdvancedLoggerBase`, the current SEC-specific library uses `ADVANCED_LOGGER_PTR`, whereas the BaseArm implementation uses `ADVANCED_LOGGER_INFO`. On ARM64 platforms, this discrepancy causes issues during the SEC phase when the BaseArm instance is limited to MM standalone usage. Specifically, the SEC instance corrupts the STMM phase buffer signature, rendering STMM logging inoperative. This update extends the BaseArm logging library to support the SEC phase as well, enabling reuse of the buffer initialized by STMM and preserving logging functionality across phases. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested This change is test on proprietary hardware. ## Integration Instructions Use `AdvLoggerPkg/Library/AdvancedLoggerLib/BaseArm/AdvancedLoggerLib.inf` for ARM64 SEC components.
Bumps [regex](https://github.com/mrabarnett/mrab-regex) from 2025.7.31 to 2025.7.34. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…icrosoft#739) ## Description This pull request brings rust fmt/clippy/doc/test validation to pull requests. Initial fixes for these are also included in this PR. The file sync commit was cherry-picked from this pull request: microsoft#737 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested This was tested by running the PR pipeline ( clippy, fmt, build, test, coverage, doc ). ## Integration Instructions N/A Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
synced local file(s) with [microsoft/mu_devops](https://github.com/microsoft/mu_devops). 🤖: View the [Repo File Sync Configuration File](https://github.com/microsoft/mu_devops/blob/main/.sync/Files.yml) to see how files are synced. --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#17437071345](https://github.com/microsoft/mu_devops/actions/runs/17437071345) --------- Signed-off-by: Project Mu UEFI Bot <uefibot@microsoft.com> Co-authored-by: mu-automation[bot] <204385837+mu-automation[bot]@users.noreply.github.com> Co-authored-by: Joey Vagedes <joey.vagedes@gmail.com>
Bumps [regex](https://github.com/mrabarnett/mrab-regex) from 2025.7.34 to 2025.9.1. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron <aaronpop@microsoft.com>
… sequence This change fixed an issue if HCR enables the exception trapping, while the VBAR is left empty, which will cause the system to fault into EL3. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
This change removes the original code path that will directly invoke the MP service protocol from AP routines. This is specifically not allowed according to the specification. Instead, the updated routine will grab the MPIDR from cached CPU info and use it for further interrupt manipulation. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
Updates the requirements on [mu_pi](https://github.com/microsoft/mu_rust_pi) to permit the latest version. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron <aaronpop@microsoft.com>
## Description Changes related to the new Tpm2HelpLib which replaces the need for Tpm2CommandLib which houses Tpm2Help.c. Reliant on microsoft/mu_tiano_plus#437 For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [x] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [ ] Backport to release branch? ## How This Was Tested Verified by building and running on physical platform. ## Integration Instructions Need to update platform .dsc to include the new Tpm2HelpLib.
## Description Removes dependencies that are not needed: - `UefiHidDxeV2`: Drop `rustversion` For users running `cargo machete`, add `mockall` to the machete ignore list in `MuTelemetryHelperLib`. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested - `cargo make all` - CI ## Integration Instructions - N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
55ae84c to
9fe4824
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All current commits to dev branch that do not exist on release branch.
How This Was Tested
CI
Integration Instructions
No integration necessary