Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

[Snyk] Security upgrade github-pages from 117 to 118#47

Open
maniator wants to merge 1 commit into
masterfrom
snyk-fix-397a643f52d8240e4a3834c900ea40c1
Open

[Snyk] Security upgrade github-pages from 117 to 118#47
maniator wants to merge 1 commit into
masterfrom
snyk-fix-397a643f52d8240e4a3834c900ea40c1

Conversation

@maniator

Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the rubygems dependencies of this project.

Snyk changed the following file(s):

  • Gemfile
  • Gemfile.lock

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Server-side Request Forgery (SSRF)
SNYK-RUBY-FARADAY-15253521
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Server-side Request Forgery (SSRF)

Copilot AI review requested due to automatic review settings February 16, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is an automated security upgrade PR created by Snyk to address an SSRF vulnerability (SNYK-RUBY-FARADAY-15253521) in the Faraday gem. The PR upgrades the github-pages gem dependency used for the Jekyll-based documentation site.

Changes:

  • Updates Gemfile to specify github-pages >= 118 instead of an unversioned dependency
  • Updates Gemfile.lock with resolved dependencies, installing github-pages version 232 (not 118 as the title suggests) and upgrading numerous transitive dependencies including the vulnerable Faraday gem from 0.11.0 to 2.14.1

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
Gemfile Adds version constraint >= 118 to github-pages gem
Gemfile.lock Updates all Jekyll and related dependencies to latest versions compatible with github-pages 232, including security fix for Faraday SSRF vulnerability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Gemfile
@@ -1,3 +1,3 @@
source "https://rubygems.org"
gem 'github-pages', group: :jekyll_plugins
gem 'github-pages', '>= 118', group: :jekyll_plugins

Copilot AI Feb 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint >= 118 allows Bundler to install version 232 (the latest available), not just version 118 as the PR title suggests. This introduces major version changes across many dependencies including activesupport (4.2.7 → 7.2.3), kramdown (1.11.1 → 2.4.0), and liquid (3.0.6 → 4.0.4), which may include breaking changes. While >= 118 ensures future security updates are automatically applied, it also means the actual upgrade scope is much larger than the PR description indicates. Consider whether a more specific constraint like ~> 118.0 would be more appropriate to limit the upgrade scope while still allowing patch-level security updates, or verify that the jump to version 232 has been tested and doesn't break the Jekyll documentation site.

Suggested change
gem 'github-pages', '>= 118', group: :jekyll_plugins
gem 'github-pages', '~> 118.0', group: :jekyll_plugins

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants