Swift: Accept standardized CSV sink labels#13115
Conversation
I think Swift should embrace the fact that we don't have a deprecation period yet and just get rid of the old labels 😃. One way of doing things is better than two in this case, I think! |
FYI, for Java I'm removing the old labels and including a change note on the PR. See #12916. |
|
OK, I've removed the old labels. I don't think we have any CSV sink models that use these particular labels, and we're not doing change notes yet, so that should be all that's needed. |
Looks like I was wrong (I searched but my terms were a bit too narrow). Fixed now. |
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once CI is happy!
There's been an effort to standardize the CSV sink labels we use between different languages. This change adds the standardized labels for Swift (but does not remove the old labels - I'm open to discussion on whether and how we should do that, but personally I don't think they're doing a lot of harm).
@jcogs33