chore(connectivity_plus): replace deprecated config in gradle 8#3867
Open
mdmahendri wants to merge 1 commit into
Open
chore(connectivity_plus): replace deprecated config in gradle 8#3867mdmahendri wants to merge 1 commit into
mdmahendri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares
connectivity_plusfor the upcoming Gradle 9 migration by resolving deprecation warnings in the build scripts. Some of these changes follow the same patterns used in #3858.Testing & Environment
This PR was tested and built successfully locally. Because it requires running
melos bootstrapwithin the repository (which depends on Dart 3.10), Flutter 3.38.1 was used for the verification process.Key Changes
For clarity and ease of review, here is a breakdown of the modifications:
1. Groovy Property Assignment Syntax
Updated Gradle property assignments to conform to the Groovy DSL requirements. Fixed the deprecation warning:
2. Modernized Lint Configuration
Migrated the
lintOptionsblock to the modernlintblock.lintOptionswas deprecated in AGP 7.2.3. Resolved Dependency Conflict
Fixed an unresolved dependency conflict between
integration_testand the example app test runner that caused the following Android Studio warning:4. Replaced Deprecated Build Directory Reference
Replaced
project.buildDirwithproject.layout.buildDirectoryto match modern Gradle API standards.5. Unified NDK Version
Added
ndkVersion = flutter.ndkVersionto resolve NDK version mismatches. Fix the following build warning:Android NDK versions are backward compatible, and the project builds and runs successfully after this change.
flutter.ndkVersionis available for version higher 3.3.0, while this package specify Flutter version 3.7.0 or higher. See this Flutter 3.3.0 release notes and PR for the revelant changeRelated Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?