Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix: Crash in auth blocking function when using with phone auth#146

Merged
taeold merged 3 commits into
firebase:mainfrom
savytskyi:patch-1
Oct 17, 2023
Merged

fix: Crash in auth blocking function when using with phone auth#146
taeold merged 3 commits into
firebase:mainfrom
savytskyi:patch-1

Conversation

@savytskyi

@savytskyi savytskyi commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

When using blocking function for phone auth, it crashes, because the dict does not seem to include "email_verified" param.

@google-cla

google-cla Bot commented Oct 9, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@savytskyi savytskyi changed the title Blocking login function: fixed crash on phone auth ("email_veried" is… Blocking login function: crashes when using with phone auth Oct 9, 2023

@taeold taeold left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing contribution - than k you so much.

@taeold taeold changed the title Blocking login function: crashes when using with phone auth fix: Crash in auth blocking function when using with phone auth Oct 10, 2023
@taeold taeold merged commit 5159a30 into firebase:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants