fix: support StringConstraints metadata in SQLAlchemy type generation#2001
Open
Sujit-1509 wants to merge 2 commits into
Open
fix: support StringConstraints metadata in SQLAlchemy type generation#2001Sujit-1509 wants to merge 2 commits into
Sujit-1509 wants to merge 2 commits into
Conversation
Member
|
@Sujit-1509, do you have specific use case there it's required to use You marked it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using Pydantic v2's
StringConstraintsinsideAnnotated, SQLModel correctly applies validation constraints but does not propagatemax_lengthto the generated SQLAlchemy column type.For example:
currently generates a column with no length constraint, even though
max_length=50is declared.Root Cause
get_field_metadata()recognizesPydanticMetadataandMaxLenmetadata objects, but does not recognizeStringConstraints, causing the metadata extractor to returnFakeMetadata()instead of the constraint object.As a result,
get_sqlalchemy_type()cannot readmax_lengthand falls back to an unconstrained string type.Changes
StringConstraintsinget_field_metadata().Annotated[str, StringConstraints(max_length=50)]produces a SQLAlchemy column withlength == 50.Testing
Added a regression test that fails on the current implementation and passes with this change.