scripts/with-go-mod: use correct minimum Go version#7040
Merged
Conversation
Follow-up to 8f7dc04, which updated the minimum Go version in vendor.mod, but did not adjust this script. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The single-line change bumps the hardcoded minimum Go version in scripts/with-go-mod.sh from go 1.24.0 to go 1.25.0, correctly aligning the script with the vendor.mod update made in commit 8f7dc04. No logic errors, correctness issues, or other concerns were found in the changed code.
vvoland
approved these changes
Jun 10, 2026
vvoland
reviewed
Jun 10, 2026
| module github.com/docker/cli | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 |
Collaborator
There was a problem hiding this comment.
Perhaps we should read it automatically from the vendor.mod?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 8f7dc04, which updated the minimum Go version in vendor.mod, but did not adjust this script.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)