Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Normalize ZeRO-3 DeepCompile grad dtype before reduction#8038

Merged
tohtana merged 3 commits into
deepspeedai:masterfrom
tohtana:tohtana/fix/deepcompile-zero3-grad-dtype-buckets
Jun 9, 2026
Merged

Normalize ZeRO-3 DeepCompile grad dtype before reduction#8038
tohtana merged 3 commits into
deepspeedai:masterfrom
tohtana:tohtana/fix/deepcompile-zero3-grad-dtype-buckets

Conversation

@tohtana

@tohtana tohtana commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Some backward kernels produce gradients in their computation dtype, not necessarily in the parameter storage dtype. For example, if a backward path accumulates or promotes math in fp32, a parameter stored as bf16 can still receive an fp32 raw gradient from that backward computation.

In normal PyTorch execution, that raw gradient reaches the leaf-gradient accumulation step, which stores it according to the tensor's expected grad dtype. ZeRO-3 DeepCompile intercepts the raw compiled-backward gradient before that leaf accumulation boundary. The reducer was assuming the raw gradient dtype was already the expected leaf grad dtype, so it could select an fp32 communication bucket even when the ZeRO grad partition storage was bf16.

To address this, this PR changes dc.reduce_grad's behavior to match PyTorch's leaf-gradient dtype contract. ZeRO-3 registration now records the expected grad dtype for each parameter, and reduce_grad normalizes raw compiled-backward gradients to that dtype before selecting the communication bucket.

This follows the documented grad_dtype behavior, including preserving explicit grad_dtype=None opt-outs: https://docs.pytorch.org/docs/main/generated/torch.sparse.semi_structured.SparseSemiStructuredTensorCUSPARSELT.html#torch.sparse.semi_structured.SparseSemiStructuredTensorCUSPARSELT.grad_dtype

Testing

  • python -m py_compile deepspeed/compile/init_z3.py tests/unit/compile/test_zero3_grad_dtype.py
  • python -m pytest -q tests/unit/compile/test_zero3_grad_dtype.py
    I confirmed both passed.

The full repro would also be useful.

@tohtana tohtana requested review from loadams and tjruwase as code owners May 30, 2026 06:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be9d1d07fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread csrc/compile/z3.cpp Outdated
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
@tohtana tohtana force-pushed the tohtana/fix/deepcompile-zero3-grad-dtype-buckets branch from be9d1d0 to 2c15ad9 Compare May 30, 2026 06:21

@eternalNight eternalNight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@tohtana tohtana enabled auto-merge (squash) June 6, 2026 20:43
@tohtana

tohtana commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

@eternalNight Thank you for your review!

@PKUWZP PKUWZP self-requested a review June 7, 2026 05:06

@PKUWZP PKUWZP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR! If you have any unit test and integration test results available, would be great to attach them as part of the PR description, thanks!

@tohtana

tohtana commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator Author

@PKUWZP Thank you for the suggestion. I added testing commands and a link to the repro.

@tohtana tohtana merged commit 4f5fb83 into deepspeedai:master Jun 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants