Highlight "distinguished" classes in the ERD #378#557
Merged
Conversation
dimitri-yatsenko
requested changes
Jan 14, 2019
code for distinguished is now limited to erd and contained within erd.py
table heading no longer has is_distinguished property. table attributes in heading no longer have is_foreign_key property.
table heading no longer has is_distinguished property. table attributes in heading no longer have is_foreign_key property.
table heading no longer has is_distinguished property. table attributes in heading no longer have is_foreign_key property.
dimitri-yatsenko
requested changes
Jan 16, 2019
1 similar comment
dimitri-yatsenko
requested changes
Jan 19, 2019
dimitri-yatsenko
left a comment
Member
There was a problem hiding this comment.
minor about ready to merge
dimitri-yatsenko
approved these changes
Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still need to update docs and test