add max_allowed_packet and bugfix in insert1 for tuples with null/nan values#183
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks like the older statement caused some valid fields to be dropped as well? Would you mind adding a test case specifically for this to ensure we don't regress in the future? :)
Contributor
Author
There was a problem hiding this comment.
This statement is not the problem. I just added is not None because it is more explicit. However, I'll add a test case for the bug above.
Contributor
Author
|
Added additional test. |
Contributor
Author
|
Wrong commit message. I meant to say logic for loading configs. |
Contributor
|
Changes look good - I will use the new config features to generate the Docker containers. |
eywalker
added a commit
that referenced
this pull request
Jan 26, 2016
add max_allowed_packet; fix bug in insert1 for tuples with null/nan values; update config loading logic
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.