perf: eliminate scala.util.Sorting from native binary#917
Merged
stephenamar-db merged 1 commit intoJun 15, 2026
Merged
Conversation
Motivation: The Profiler was the only code path using scala.util.Sorting (via .sortBy and .sorted), pulling in 96KB of dead code into the native binary (88KB __text + 8KB __eh_frame) that is never exercised during normal evaluation. Modification: - Replace aggregated.toSeq.sortBy(-_.selfTimeNs) with java.util.Arrays.sort using a Comparator - Replace samples.sorted.apply(median) with in-place java.util.Arrays.sort followed by direct index access Result: Native binary __text reduced by 88KB, __eh_frame by 8KB. No behavioral change — Profiler output is identical.
stephenamar-db
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
scala.util.Sortingfrom the native binary by replacing two calls inProfiler.scalawithjava.util.Arrays.sort.The Profiler was the only code path pulling in
scala.util.Sorting— this saves 96KB from the native binary (88KB__text+ 8KB__eh_frame), code that is never exercised during normal Jsonnet evaluation.Changes
aggregated.toSeq.sortBy(-_.selfTimeNs)java.util.Arrays.sort(arr, comparator)samples.sorted.apply(median)java.util.Arrays.sort(samples); samples(median)Test plan