Remove user-declared default, copy and move constructors#548
Merged
Conversation
Removed the following defaulted constructors: * Default Constructor * Copy Constructor * Move Constructor The defaulted move constructor prevents implicit declaration of the copy assignment operator, which results in compiler errors since std::promise requires it. All 3 user-declared methods removed here are implicitly declared by the compiler anyway, so no need to default them in the first place. Relates to cpp-netlib#547
b0f60b0 to
dd69300
Compare
glynos
added a commit
that referenced
this pull request
Aug 7, 2015
Remove user-declared default, copy and move constructors
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaulted move constructor prevents implicit declaration of the copy assignment operator, which results in compiler errors since std::promise requires it.
All 3 user-declared methods removed here are implicitly declared by the compiler anyway, so no need to default them in the first place.
Relates to #547