Replacing setTextValue → setText, setText2Value → setText2, setDescriptionValue → setDescription#41
Merged
Conversation
…ptionValue → setDescription.
There was a problem hiding this comment.
Pull request overview
This PR updates progress/presentation API usage across the Python implementation module by replacing deprecated *Value setter calls with the newer setter method names.
Changes:
- Replace
setTextValue(...)withsetText(...)on progress indicators and presentations. - Replace
setText2Value(...)withsetText2(...)on progress indicators.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python-impl/src/main/java/com/jetbrains/python/impl/sdk/skeletons/PySkeletonRefresher.java | Updates progress indicator text setters to the new API names. |
| python-impl/src/main/java/com/jetbrains/python/impl/sdk/PythonSdkUpdater.java | Updates progress indicator messaging during SDK skeleton/package refresh. |
| python-impl/src/main/java/com/jetbrains/python/impl/sdk/AbstractCreateVirtualEnvDialog.java | Updates progress indicator text setter while creating virtualenv. |
| python-impl/src/main/java/com/jetbrains/python/impl/packaging/setupPy/CreateSetupPyAction.java | Updates template presentation text setter to the new API name. |
| python-impl/src/main/java/com/jetbrains/python/impl/debugger/PyDebugProcess.java | Updates connection progress indicator text setter. |
| python-impl/src/main/java/com/jetbrains/python/impl/console/PythonDebugLanguageConsoleView.java | Updates action presentation text setter to the new API name. |
| python-impl/src/main/java/com/jetbrains/python/impl/console/PydevConsoleRunnerImpl.java | Updates console connection progress indicator text setter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+161
to
+165
| indicator.setText(LocalizeValue.localizeTODO("Updating skeletons...")); | ||
| PySkeletonRefresher.refreshSkeletonsOfSdk(project1, ownerComponent, skeletonsPath, sdkInsideTask); | ||
| indicator.setIndeterminate(true); | ||
| indicator.setTextValue(LocalizeValue.localizeTODO("Scanning installed packages...")); | ||
| indicator.setText2Value(LocalizeValue.empty()); | ||
| indicator.setText(LocalizeValue.localizeTODO("Scanning installed packages...")); | ||
| indicator.setText2(LocalizeValue.empty()); |
There was a problem hiding this comment.
The PR title mentions replacing setDescriptionValue → setDescription, but there don’t appear to be any setDescriptionValue usages in the repo (and none changed in this PR). Consider updating the title to reflect only the actual replacements, or include the missing setDescriptionValue change if it was intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.