Explicitly add pydantic dependency to http provider#68321
Open
dabla wants to merge 2 commits into
Open
Conversation
1 task
Dev-iL
approved these changes
Jun 10, 2026
Collaborator
There was a problem hiding this comment.
No objection to this in general. One question though: which version does the provider actually needs to function? >=2.0.0? Most places that declare pydantic as a dep use 2.11.0, but apache-airflow-registry-tools uses 2.12.0 (where the latest is 2.13.x).
Contributor
Author
2.11.0 should be fine for this case, I just need BaseModel, that's all. |
4be8987 to
286fb1a
Compare
286fb1a to
d7b62ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by @NBardelot, the HTTP provider now also has a direct dependency on Pydantic due to the addition of the
SessionConfigclass in the HTTP hooks module.Although the
pydanticdependency is currently resolved transitively through theairflow-coredependency, it is generally considered best practice to declare direct dependencies explicitly in the provider itself. Otherwise, the provider could break in the future ifpydanticis removed from, or no longer exposed throughairflow-coredependency tree.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.