Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Explicitly add pydantic dependency to http provider#68321

Open
dabla wants to merge 2 commits into
apache:mainfrom
dabla:fix/add-pydantic-to-http-provider
Open

Explicitly add pydantic dependency to http provider#68321
dabla wants to merge 2 commits into
apache:mainfrom
dabla:fix/add-pydantic-to-http-provider

Conversation

@dabla

@dabla dabla commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

As mentioned by @NBardelot, the HTTP provider now also has a direct dependency on Pydantic due to the addition of the SessionConfig class in the HTTP hooks module.

Although the pydantic dependency is currently resolved transitively through the airflow-core dependency, it is generally considered best practice to declare direct dependencies explicitly in the provider itself. Otherwise, the provider could break in the future if pydantic is removed from, or no longer exposed through airflow-core dependency tree.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Dev-iL Dev-iL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to this in general. One question though: which version does the provider actually needs to function? >=2.0.0? Most places that declare pydantic as a dep use 2.11.0, but apache-airflow-registry-tools uses 2.12.0 (where the latest is 2.13.x).

@dabla

dabla commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

No objection to this in general. One question though: which version does the provider actually needs to function? >=2.0.0? Most places that declare pydantic as a dep use 2.11.0, but apache-airflow-registry-tools uses 2.12.0 (where the latest is 2.13.x).

2.11.0 should be fine for this case, I just need BaseModel, that's all.

@dabla dabla force-pushed the fix/add-pydantic-to-http-provider branch from 4be8987 to 286fb1a Compare June 10, 2026 09:08
@dabla dabla force-pushed the fix/add-pydantic-to-http-provider branch from 286fb1a to d7b62ea Compare June 10, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants