Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

updated llama.cpp to b2861#1449

Closed
Man2Dev wants to merge 1 commit into
abetlen:mainfrom
Man2Dev:main
Closed

updated llama.cpp to b2861#1449
Man2Dev wants to merge 1 commit into
abetlen:mainfrom
Man2Dev:main

Conversation

@Man2Dev
Copy link
Copy Markdown

@Man2Dev Man2Dev commented May 12, 2024

fixes cmake bug

@abetlen
Copy link
Copy Markdown
Owner

abetlen commented May 13, 2024

@Man2Dev thank you for the contribution however I usually handle the submodule updates just so I can manually review the upstream changes.

As for the issue, I see there's a fix for the version check, was it failing to set the correct cmake min version requirement?

@Man2Dev
Copy link
Copy Markdown
Author

Man2Dev commented May 13, 2024

@Man2Dev thank you for the contribution however I usually handle the submodule updates just so I can manually review the upstream changes.

As for the issue, I see there's a fix for the version check, was it failing to set the correct cmake min version requirement?

I didn't check i was trying to update the python-llama-cpp package in fedora and saw fix come in right after the submodule update so i thought i would point it out.

@abetlen
Copy link
Copy Markdown
Owner

abetlen commented May 14, 2024

@Man2Dev appreciate it

@abetlen abetlen closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants