updated llama.cpp to b2861#1449
Closed
Man2Dev wants to merge 1 commit into
Closed
Conversation
Owner
|
@Man2Dev thank you for the contribution however I usually handle the submodule updates just so I can manually review the upstream changes. As for the issue, I see there's a fix for the version check, was it failing to set the correct cmake min version requirement? |
Author
I didn't check i was trying to update the python-llama-cpp package in fedora and saw fix come in right after the submodule update so i thought i would point it out. |
Owner
|
@Man2Dev appreciate it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes cmake bug