Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

235 home icon for breadcrumbs is always the root no base url#236

Merged
willbreitkreutz merged 3 commits into
mainfrom
235-home-icon-for-breadcrumbs-is-always-the-root-no-base_url
Sep 8, 2025
Merged

235 home icon for breadcrumbs is always the root no base url#236
willbreitkreutz merged 3 commits into
mainfrom
235-home-icon-for-breadcrumbs-is-always-the-root-no-base_url

Conversation

@krowvin

@krowvin krowvin commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Corrects issue with Home icon for breadcrumbs always set to / even if a site has a BASE_URL set.

This lets you provide an optional baseURL to the <Breadcrumbs /> component.

@krowvin krowvin linked an issue Aug 27, 2025 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

Please set a versioning label of either major-bump, minor-bump, or patch-bump to the pull request.

@willbreitkreutz willbreitkreutz merged commit eb0df36 into main Sep 8, 2025
2 checks passed
krowvin added a commit that referenced this pull request Dec 17, 2025
* Add baseUrl prop to Breadcrumbs component

* Test baseUrl crumb prop against the doc site itself

* Update the breadcrumbs docs to reflect prop changes
@krowvin krowvin deleted the 235-home-icon-for-breadcrumbs-is-always-the-root-no-base_url branch April 13, 2026 15:19
krowvin added a commit that referenced this pull request May 5, 2026
* Correct existing base_url references from base to BASE_URL. Ensure we are now not using doUpdateUrlWithBase and correct trailing slash.

* Add BASE_URL to the lib Breadcrumbs/Header Image

* Add # to our base in the vite config for the Docs site and remove trailing slash

* In the button show a base_url example and add a note about it

* Can't have a hash in the base for vite!

* Remove prepended slash, add missing BASE_URL

* Add onclick catch to allow baseurl/# in the href paths

* Add missing baseurl to logout/login-button

* Add missing baseurl

* Remove unused comments

* Fix popout menu header path, +base_url

* Ensure baseurl with the hash if the hash is not present in the initial URL request

* Passing in additional headless ui props and updated documentation (#232)

* 3.15.0

* Modal update (#234)

* Passing in additional headless ui props and updated documentation

* Fixed all issues

* 3.15.1

* 239 add issuefeature templates (#240)

* Add config to reference other libs

* Add bug report

* Add feature request

* 235 home icon for breadcrumbs is always the root no base url (#236)

* Add baseUrl prop to Breadcrumbs component

* Test baseUrl crumb prop against the doc site itself

* Update the breadcrumbs docs to reflect prop changes

* 3.15.2

* Keep text component, fix contrast (#252)

Co-authored-by: Charles Graham <charles.r.graham@usace>

* 3.15.3

* bump version of vite to satisfy npm audit (#226)

* 3.15.4

* Bump js-yaml from 4.1.0 to 4.1.1 (#250)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 3.15.5

* Bump vite from 7.1.2 to 7.2.7 (#253)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.2 to 7.2.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v7.2.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.2.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.2.7
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 3.15.6

* Typos and wrong paths

* Getting started path does not exist

* Missing #

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Brian Mulcahy <bmulcahy@users.noreply.github.com>
Co-authored-by: willbreitkreutz <will.l.breitkreutz@usace.army.mil>
Co-authored-by: Charles Graham <charles.r.graham@usace>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home Icon for Breadcrumbs is Always the Root (No BASE_URL)

2 participants