Add conda meta.yaml [draft]#103
Draft
mdavis-xyz wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #102
I've added this same file to conda staged-recipes.
Unfortunately it seems that if we publish on Conda forge, dependencies need to be mentioned both in pyproject.yaml and meta.yaml. So this is a duplication and risk for drift. However I'm still not sure how essential it is to keep
meta.yamlin this repo. After the initial PR to add Nemosis to conda (here) I think that Conda uses scripts to check for updates on Pypi, and updates accordingly. Additionally, we don't need to update github actions to add any conda steps to the existing pypi publication steps.I could be wrong though. This is still new to me.
Wait until that other PR is merged before merging this one.