Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Integration with Apache EventMesh#17

Merged
benjaminhuo merged 2 commits into
OpenFunction:masterfrom
xwm1992:add-eventmesh-trigger
Sep 19, 2023
Merged

Integration with Apache EventMesh#17
benjaminhuo merged 2 commits into
OpenFunction:masterfrom
xwm1992:add-eventmesh-trigger

Conversation

@xwm1992

@xwm1992 xwm1992 commented Aug 14, 2023

Copy link
Copy Markdown

Fixed issue #480

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@xwm1992

xwm1992 commented Aug 21, 2023

Copy link
Copy Markdown
Author

Ok, I'll fix these issues.

@xwm1992 xwm1992 requested a review from wanjunlei September 18, 2023 04:51
@wanjunlei

Copy link
Copy Markdown
Member

@xwm1992 The DCO is required, please resolve it first.

@benjaminhuo

Copy link
Copy Markdown
Member

git commit -s --amend
git push -f

@xwm1992 xwm1992 force-pushed the add-eventmesh-trigger branch from 87067c3 to fba11c2 Compare September 18, 2023 09:31
Signed-off-by: xwm1992 <mike_xwm@126.com>
@xwm1992 xwm1992 force-pushed the add-eventmesh-trigger branch from fba11c2 to 4d5ccae Compare September 19, 2023 07:42
…amework-java into add-eventmesh-trigger

� Conflicts:
�	functions-framework-api/src/main/java/dev/openfunction/functions/Context.java
�	functions-framework-invoker/pom.xml
�	functions-framework-invoker/src/main/java/dev/openfunction/invoker/context/UserContext.java
�	samples/pom.xml
@xwm1992

xwm1992 commented Sep 19, 2023

Copy link
Copy Markdown
Author

@xwm1992 The DCO is required, please resolve it first.

I've resolved the DCO problem, please review thanks.

@wanjunlei

Copy link
Copy Markdown
Member

Thanks for your commit.

Eventmesh should use separate input and output, and should not use dapr's input and output. Going further, we need to support the mixed-use of eventmesh and dapr. For example, use the dapr trigger to trigger the function, then get data from eventmesh input, and then send the results to dapr output and eventmesh output at the same time. I will merge this PR first and then we need to consider how to implement these later.

type EventmeshOutput struct {

}

type Output struct {
	Dapr *DaprOutput `json:"dapr,omitempty"`
        Eventmesh *EventmeshOutput `json:"eventmesh,omitempty"`
}

@benjaminhuo benjaminhuo merged commit e7503cb into OpenFunction:master Sep 19, 2023
@benjaminhuo

Copy link
Copy Markdown
Member

To integrate EventMesh with OpenFunction, what else should be done except this change? @wanjunlei @xwm1992

@wanjunlei

Copy link
Copy Markdown
Member

It need add the eventmesh config into the Function CRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration with Apache EventMesh

4 participants