Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Disambiguate deprecation notice in disallow results from triggers#8959

Closed
fredericDelaporte wants to merge 1 commit intoMicrosoftDocs:livefrom
fredericDelaporte:patch-1
Closed

Disambiguate deprecation notice in disallow results from triggers#8959
fredericDelaporte wants to merge 1 commit intoMicrosoftDocs:livefrom
fredericDelaporte:patch-1

Conversation

@fredericDelaporte
Copy link
Copy Markdown
Contributor

@fredericDelaporte fredericDelaporte commented May 17, 2023

The disallow results from triggers configuration option documentation has a deprecation notice about the ability to return result sets from triggers. But a generic deprecation notice is used, with the wording "this feature".

It is unclear whether "this feature" refers to the configuration option or to the feature of returning result sets from triggers. With the sentence "We recommend that you set this value to 1." added after the notice, we can understand that the notice is about the feature, not the option. But still, that is confusing.

It appears older versions of the documentation, dating back to MSDN, were more clear:

The ability to return result sets from triggers will be removed in a future version of SQL Server. Avoid returning result sets from triggers in new development work, and plan to modify applications that currently do this. To prevent triggers from returning result sets in SQL Server 2005, set the disallow results from triggers Option to 1. The default setting of this option will be 1 in a future version of SQL Server.

(Seen here.)

This change combines the older documentation with the generic deprecation notice.

So, current notice is:

This feature will be removed in a future version of Microsoft SQL Server. Avoid using this feature in new development work, and plan to modify applications that currently use this feature. We recommend that you set this value to 1.

Proposed change would cause it to be:

The ability to return result sets from triggers is deprecated. This feature will be removed in a future version of Microsoft SQL Server. Avoid using this feature in new development work, and plan to modify applications that currently use this feature. We recommend that you set this value to 1.

Maybe it should be more explicit about value too, like this:

The ability to return result sets from triggers is deprecated. This feature will be removed in a future version of Microsoft SQL Server. Avoid using this feature in new development work, and plan to modify applications that currently use this feature. We recommend that you set this option value to 1.

The `disallow results from triggers` configuration option documentation has a deprecation notice about the ability to return result sets from triggers. But a generic deprecation notice is used, with the wording "this feature".

It is unclear whether "this feature" refers to the configuration option or to the feature of returning result sets from triggers. With the sentence "We recommend that you set this value to 1." added after the notice, we can understand that the notice is about the feature, not the option. But still, that is confusing.

It appears older versions of the documentation, dating back to MSDN, were more clear:
> The ability to return result sets from triggers will be removed in a future version of SQL Server. Avoid returning result sets from triggers in new development work, and plan to modify applications that currently do this. To prevent triggers from returning result sets in SQL Server 2005, set the disallow results from triggers Option to 1. The default setting of this option will be 1 in a future version of SQL Server.

(Seen [here](https://stackoverflow.com/a/30915837/1178314).)

This change combines the older documentation with the generic deprecation notice.
@prmerger-automator
Copy link
Copy Markdown
Contributor

@fredericDelaporte : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 47f5132:

✅ Validation status: passed

File Status Preview URL Details
docs/database-engine/configure-windows/disallow-results-from-triggers-server-configuration-option.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Copy Markdown
Contributor

Court72 commented May 17, 2023

@rwestMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged tracking label for the PR review team label May 17, 2023
@rwestMSFT
Copy link
Copy Markdown
Contributor

@fredericDelaporte Thanks for your feedback. We'll look into it.

@fredericDelaporte fredericDelaporte changed the title DIsambiguate deprecation notice in disallow results from triggers Disambiguate deprecation notice in disallow results from triggers May 24, 2023
@rwestMSFT
Copy link
Copy Markdown
Contributor

@fredericDelaporte The article needs some other minor tweaks, so we'll take this PR and merge it internally with another one, and you'll still get credit.

Thanks for your contribution! The updated article should publish in the next day or so.

@rwestMSFT rwestMSFT closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants