Disambiguate deprecation notice in disallow results from triggers#8959
Disambiguate deprecation notice in disallow results from triggers#8959fredericDelaporte wants to merge 1 commit intoMicrosoftDocs:livefrom
Conversation
The `disallow results from triggers` configuration option documentation has a deprecation notice about the ability to return result sets from triggers. But a generic deprecation notice is used, with the wording "this feature". It is unclear whether "this feature" refers to the configuration option or to the feature of returning result sets from triggers. With the sentence "We recommend that you set this value to 1." added after the notice, we can understand that the notice is about the feature, not the option. But still, that is confusing. It appears older versions of the documentation, dating back to MSDN, were more clear: > The ability to return result sets from triggers will be removed in a future version of SQL Server. Avoid returning result sets from triggers in new development work, and plan to modify applications that currently do this. To prevent triggers from returning result sets in SQL Server 2005, set the disallow results from triggers Option to 1. The default setting of this option will be 1 in a future version of SQL Server. (Seen [here](https://stackoverflow.com/a/30915837/1178314).) This change combines the older documentation with the generic deprecation notice.
|
@fredericDelaporte : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 47f5132: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
|
@fredericDelaporte Thanks for your feedback. We'll look into it. |
|
@fredericDelaporte The article needs some other minor tweaks, so we'll take this PR and merge it internally with another one, and you'll still get credit. Thanks for your contribution! The updated article should publish in the next day or so. |
The
disallow results from triggersconfiguration option documentation has a deprecation notice about the ability to return result sets from triggers. But a generic deprecation notice is used, with the wording "this feature".It is unclear whether "this feature" refers to the configuration option or to the feature of returning result sets from triggers. With the sentence "We recommend that you set this value to 1." added after the notice, we can understand that the notice is about the feature, not the option. But still, that is confusing.
It appears older versions of the documentation, dating back to MSDN, were more clear:
(Seen here.)
This change combines the older documentation with the generic deprecation notice.
So, current notice is:
Proposed change would cause it to be:
Maybe it should be more explicit about
valuetoo, like this: