Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

fix: Add extension to ~/ link#1164

Closed
nschonni wants to merge 1 commit intoMicrosoftDocs:livefrom
nschonni:patch-2
Closed

fix: Add extension to ~/ link#1164
nschonni wants to merge 1 commit intoMicrosoftDocs:livefrom
nschonni:patch-2

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

Flagged in #1148 (review) but didn't get fixed before the PR landed

@PRMerger18
Copy link
Copy Markdown
Contributor

@nschonni : Thanks for your contribution! The author, @MightyPen, has been notified to review your proposed change.

@MightyPen
Copy link
Copy Markdown
Contributor

@nschonni Hi Nick, My PR 1148 comment was only a HowTo FYI for the future. My teammate Doug L. created another PR to fix the 1148 links.

We do Not like to have links start with '~', nor with '/sql/' (except in uncommon special cases). We prefer relative pathing according to the GitHub folder structure.
Also, the '.md' extension is needed when relative pathing is used, but '.md' is forbidden in any other syntax.

I am calling for this PR 1164 to be permanently Closed, partly because it has become a duplicated given Doug L.'s very recent private PR.
Thanks.

@MightyPen
Copy link
Copy Markdown
Contributor

#please-close

@MightyPen MightyPen closed this Oct 24, 2018
@nschonni nschonni deleted the patch-2 branch October 24, 2018 20:39
@nschonni
Copy link
Copy Markdown
Contributor Author

We do Not like to have links start with '~', nor with '/sql/' (except in uncommon special cases). We prefer relative pathing according to the GitHub folder structure.
Also, the '.md' extension is needed when relative pathing is used, but '.md' is forbidden in any other syntax.

Yup, that original PR was a little fake an partially because the issue tracker isn't open on this repo #1148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants