Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Shape detection#632

Merged
CodeDoctorDE merged 19 commits into
LinwoodDev:developfrom
MrGumpIT:shapeDetection
Mar 21, 2024
Merged

Shape detection#632
CodeDoctorDE merged 19 commits into
LinwoodDev:developfrom
MrGumpIT:shapeDetection

Conversation

@MrGumpIT

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Mar 16, 2024

Copy link
Copy Markdown

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

@CodeDoctorDE

Copy link
Copy Markdown
Member

Can you please merge this by updating (sync) your develop branch, use git merge
and remove this file while merging and then run dart run build_runner build inside api?

@vercel

vercel Bot commented Mar 16, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview Mar 21, 2024 3:01pm

@vercel vercel Bot temporarily deployed to Preview – butterfly March 16, 2024 16:43 Inactive
Comment thread app/lib/handlers/pen.dart Outdated
Comment thread app/lib/handlers/pen.dart Outdated
Comment thread app/lib/handlers/pen.dart Outdated
Comment thread app/lib/handlers/pen.dart Outdated
@vercel vercel Bot temporarily deployed to Preview – butterfly-docs March 17, 2024 15:40 Inactive
@vercel vercel Bot temporarily deployed to Preview – butterfly March 17, 2024 15:41 Inactive
Comment thread app/lib/handlers/pen.dart Outdated
@vercel vercel Bot temporarily deployed to Preview – butterfly March 19, 2024 18:00 Inactive
@vercel vercel Bot temporarily deployed to Preview – butterfly-docs March 19, 2024 18:05 Inactive
Comment thread app/lib/handlers/pen.dart Outdated
default:
// Manage custom shapes here
}
} else if (points.length > 500) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand why else if and not else?
If points < 500 and it doesn't recognize anything it clears it?
I don't think that's really good.

I would just make a guard clause and return if element == null or points > 500 (but I would remove this once we fixed the issue)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a leftover. Else enough. If you can change it as well

@vercel vercel Bot temporarily deployed to Preview – butterfly March 21, 2024 15:01 Inactive
@vercel vercel Bot temporarily deployed to Preview – butterfly-docs March 21, 2024 15:01 Inactive

@CodeDoctorDE CodeDoctorDE left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@CodeDoctorDE CodeDoctorDE merged commit 1e596fb into LinwoodDev:develop Mar 21, 2024
@MrGumpIT MrGumpIT deleted the shapeDetection branch April 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants