Disable build-time document generation#2684
Open
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
Open
Disable build-time document generation#2684dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
dmytro-pryvedeniuk wants to merge 3 commits intoJasperFx:mainfrom
Conversation
Contributor
Author
|
Build logs can be found below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables OpenAPI/Swagger document generation to speed up build time and avoid annoying build failures.
I used native OpenAPI provided by
Microsoft.AspNetCore.OpenApiinstead ofSwashbuckle.AspNetCorein the most of sample projects. It required skipping net8 from TargetFrameworks asAddOpenApi/MapOpenApimethods are available in net9.0+.WolverineWebApiis the only project heavily using Swagger so I just disabled build-time document generation there usingOpenApiGenerateDocumentsOnBuild.In all cases below I used Rebuild from VS2026 with stopped docker containers.
Case 1 - Whole solution (21.20mins vs 38.44mins+9 failed projects)
With my changes:
Without:
Case 2 - Single WebAppWithSQS project (23s vs 2.45mins+failed build)
With my changes:
Without (document generation emits multiple errors about not available broker).
Case 3 - Single WolverineWebApi project (45s vs 2.30mins)
With my changes:
Without (build succeeds here, even without docker containers)