Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Leverage 'imdb_id" for TMDB movie lookup#103

Merged
kristenmills merged 4 commits into
Flexget:developfrom
evoblicec:patch-1
Apr 14, 2020
Merged

Leverage 'imdb_id" for TMDB movie lookup#103
kristenmills merged 4 commits into
Flexget:developfrom
evoblicec:patch-1

Conversation

@evoblicec

Copy link
Copy Markdown
Contributor

Motivation for changes:

Wrong movie details is displayed in "Movie list" view, for entry with imdb_id but no tmdb_id.

WEBui only leverage tmdb_id and movie.title for API TMDB lookup. Even if `imdb_id' is available for the entry.

Flexget TMDB API can leverage imdb_id to research a movie when tmdb_id is not provided. Results are more accurate than searching by title.
See recent commit

This change add the imdb_id field to the API TMDB request in useMovieLookup used when displaying "Movie Lists" tab.

Detailed changes:

  • Add imdb_id along tmdb_id in request to TMDB API from useMovieLookup

Addressed issues:

  • WEBui only leverage tmdb_id and movie.title for API TMDB lookup. Even if `imdb_id' is available for the entry.

Implemented feature requests:

  • N.A

To Do:

  • N.A

Flexget TMDB API can leverage 'imdb_id' to research a movie when 'tmdb_id' is provided. Results are more accurate than searching by title.

This change add the 'imdb_id' field to the API TMDB request in "useMovieLookup" used when displaying "Movie Lists" tab.
@codecov

codecov Bot commented Apr 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #103 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #103   +/-   ##
========================================
  Coverage    90.72%   90.72%           
========================================
  Files          128      128           
  Lines         2738     2738           
  Branches       439      439           
========================================
  Hits          2484     2484           
  Misses         250      250           
  Partials         4        4           
Impacted Files Coverage Δ
src/core/entry/lookup/movies.ts 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab2e2e...58d98ae. Read the comment docs.

@kristenmills kristenmills self-requested a review April 14, 2020 22:23

@kristenmills kristenmills left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🙏

@kristenmills kristenmills merged commit c5cac8b into Flexget:develop Apr 14, 2020
@evoblicec evoblicec deleted the patch-1 branch April 26, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants