Leverage 'imdb_id" for TMDB movie lookup#103
Merged
Merged
Conversation
Flexget TMDB API can leverage 'imdb_id' to research a movie when 'tmdb_id' is provided. Results are more accurate than searching by title. This change add the 'imdb_id' field to the API TMDB request in "useMovieLookup" used when displaying "Movie Lists" tab.
Codecov Report
@@ Coverage Diff @@
## develop #103 +/- ##
========================================
Coverage 90.72% 90.72%
========================================
Files 128 128
Lines 2738 2738
Branches 439 439
========================================
Hits 2484 2484
Misses 250 250
Partials 4 4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Wrong movie details is displayed in "Movie list" view, for entry with
imdb_idbut notmdb_id.WEBui only leverage
tmdb_idandmovie.titlefor API TMDB lookup. Even if `imdb_id' is available for the entry.Flexget TMDB API can leverage
imdb_idto research a movie whentmdb_idis not provided. Results are more accurate than searching by title.See recent commit
This change add the
imdb_idfield to the API TMDB request inuseMovieLookupused when displaying "Movie Lists" tab.Detailed changes:
imdb_idalongtmdb_idin request to TMDB API fromuseMovieLookupAddressed issues:
tmdb_idandmovie.titlefor API TMDB lookup. Even if `imdb_id' is available for the entry.Implemented feature requests:
To Do: