refresh udp ip at some cadence#280
Open
blakearnold wants to merge 4 commits into
Open
Conversation
|
@AliDatadog @wdhif Is there any chance this PR will be included in a release? |
|
Just ran into this issue today with a dns change that occurred against a remote instance of the datadog-agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked #264, but put the refresh in a separate go routine for performance.
The current UDP connection logic will resolve an address only when the writer is created. This is undesirable in cases where the address may change at a later point.
This should also fix #263.